Implements customElements.getName() and fixes letter case handling. #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mash-graz
force-pushed
the
feature-getName
branch
from
0e14dbb to
1997a86
Compare
mash-graz
force-pushed
the
feature-getName
branch
from
57ad4d7 to
36b2c8e
Compare
…o feature-getName
|
I'm looking into this. Still some more things I want to check. |
There is no hurry. :) Unfortunately I'm also rather busy with other jobs. Therefor I also couldn't review your extensive node-dependency-reduction-solution util now, but I will take a look as soon as possible. |
…ment() and Document.createElementNS()
capricorn86
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the getName() method was a rather trivial task, but it doesn't make much sense without trying to fix the much more complicated letter case resp. case-sensitivity issues regarding the custom element registry, because otherwise we would return an invalid identifier.
The custom element specification requires names, that do not contain capital ASCII letters and case-sensitive letters of some Unicode ranges. It's closer the XML conventions than traditional HTML. To emphasize this difference I also used the variable name
localNameinstead oftagNamein the relevant code sections, becauseelement.tagNamewill always use capital letters, while the correspondinglocalNamemostly uses lowercase.Fixes: #1176